SOLR-18332: More qt-removal from tests, rd 2 - #4713
Open
gerlowskija wants to merge 2 commits into
Open
Conversation
Tests pass
Focuses on solr-core tests, especially those descended from BaseDistributedSearchTestCase and that rely on certain `query()` test helpers available to this class. Many 'qt' usages remain, but this is a second round of the removals.
Contributor
Author
|
(FYI @dsmiley ) |
epugh
reviewed
Aug 6, 2026
| } | ||
|
|
||
| QueryRequest qr = new QueryRequest(params("qt", "/get", "id", "1000")); | ||
| QueryRequest qr = new QueryRequest("/get", params("id", "1000")); |
epugh
reviewed
Aug 6, 2026
| } | ||
| }"""; | ||
| QueryResponse rsp = query(CommonParams.JSON, jsonQuery, CommonParams.QT, "/search-elevate"); | ||
| QueryResponse rsp = query("/search-elevate", params(CommonParams.JSON, jsonQuery)); |
epugh
reviewed
Aug 6, 2026
| Thread.sleep(100); | ||
|
|
||
| queryPartialResults( | ||
| "/select", |
Contributor
There was a problem hiding this comment.
i think I even like better this bit of verbose ness!
Contributor
|
Poked around a bit at your "rd 2" changes, it all looks great to me.... |
Contributor
Author
Haha, hopefully "rd 2" isn't too obscure. "Round 2" abbreviated to fit in a commit-message title. Thanks for taking the time to review! |
Contributor
|
Thanks for making progress here :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 'qt' parameter and several related methods in SolrJ are deprecated.
This deprecation may not stick, but it's still worth minimizing use of this
feature as much as possible.
Many tests rely on it unnecessarily; this PR is one in a number of batches
slowly removing these usages. This one in particular focuses on
solr-core tests, especially those descended from
BaseDistributedSearchTestCase and that rely on certain
query()testhelpers available to this class.