Bump Solr 9x to latest opennlp 1.9.5#4555
Open
epugh wants to merge 3 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR pins org.apache.opennlp:opennlp-tools to 1.9.5 on Solr 9.x (overriding the version otherwise inherited via Lucene) to pick up CVE fixes, and updates the dependency lock and license checksum metadata accordingly.
Changes:
- Add an explicit
opennlp-toolsversion override (1.9.5) inversions.props. - Update
versions.lockto reflect the resolvedopennlp-toolsversion. - Refresh license checksum files by adding the 1.9.5 SHA1 and removing the 1.9.4 SHA1.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
versions.props |
Pins opennlp-tools to 1.9.5 via a version override. |
versions.lock |
Updates the resolved/locked dependency version to 1.9.5. |
solr/licenses/opennlp-tools-1.9.5.jar.sha1 |
Adds checksum metadata for the new opennlp-tools jar version. |
solr/licenses/opennlp-tools-1.9.4.jar.sha1 |
Removes checksum metadata for the old opennlp-tools jar version. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
Thanks @atarora for cutting the OpenNLP release, here is the bump to Solr 9... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update to latest 1.9.x release of OpenNLP that fixes some CVE's.
Solution
Inspired by #1424, which removed pinning of opennlp to rely on Lucene's version, this undoes that and pins to 1.9.5 instead of the one that lucene relies on 1.9.4.
I will also open a PR against Lucene 9x in case there is ever a release of that to pick this up.
Tests
Re run existing tests.