SOLR-18077: Fix incorrect request reuse, fix unit tests.#4396
Merged
sigram merged 4 commits intoapache:mainfrom May 6, 2026
Merged
SOLR-18077: Fix incorrect request reuse, fix unit tests.#4396sigram merged 4 commits intoapache:mainfrom
sigram merged 4 commits intoapache:mainfrom
Conversation
…sed. Fix unit tests.
epugh
reviewed
May 5, 2026
| @@ -75,6 +75,8 @@ | |||
| public class KafkaCrossDcConsumer extends Consumer.CrossDcConsumer { | |||
| private static final Logger log = LoggerFactory.getLogger(MethodHandles.lookup().lookupClass()); | |||
|
|
|||
Contributor
There was a problem hiding this comment.
is this option so specific to a developer that no user would ever concievable want to enable it? If it might be neabled by a user, it would be nice to add it to our solr-properties.adoc file to explain what it is.
Contributor
Author
There was a problem hiding this comment.
This exposes a really low-level info that IMHO is useful only for verifying the key / partition assignments, so it makes sense for a developer but unlikely useful to an ops person.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in KafkaCrossDcConsumer where an
updateReqBatchrequest used for collapsing multiple input requests would be left non-null and then incorrectly reused. This resulted in the same document updates being sometimes sent to Solr multiple times.Added unit test to verify the number of processed updates.