SOLR-18046 RateLimitFilter, rename EssentialSolrRequestFilter #4065
+179
−152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsmiley
reviewed
Jan 20, 2026
Contributor
dsmiley
left a comment
dsmiley
left a comment
There was a problem hiding this comment.
Thanks for working on this!
solr/test-framework/src/java/org/apache/solr/embedded/JettySolrRunner.java
Show resolved
Hide resolved
solr/core/src/java/org/apache/solr/servlet/CoreContainerAwareHttpFilter.java
Show resolved
Hide resolved
Contributor
Author
Tests passed many times (and failed on a few flaky test failures) locally. This has been available for review, and all comments other than the one-liner removal of the volatile modifier resolved for several days. Will merge this evening unless objections are raised regardless of what crave is (or isn't) doing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-18046
In addition to Rate limiting, Renamed EssentialSolrRequestFilter as per subsequent discussion after SOLR-18044 was committed.