fix: fall back to current time when alert dateCreated is null in EmailAlertNotifyStrategy (#6866) - #6964
Open
juicewcode wants to merge 1 commit into
Open
Conversation
…ilAlertNotifyStrategy (apache#6866) buildAlertHtmlTemplate null-guarded Objects.isNull(alert) (dead code) instead of alertTime, so a null dateCreated left alertTime null and format() threw NPE, breaking the email notify path. Guard alertTime and fall back to new Date(); adds EmailAlertNotifyStrategyTest for the null and normal paths.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6866
Summary
EmailAlertNotifyStrategy.buildAlertHtmlTemplate null-guarded the wrong variable: Objects.isNull(alert) is dead code (alert already dereferenced). When dateCreated is null, alertTime stayed null and SimpleDateFormat.format() threw NPE, crashing the email notify path. Now guards alertTime and falls back to new Date(), matching AbstractAlertNotifyHandler.
Added EmailAlertNotifyStrategyTest:
Make sure that:
./mvnw clean install -Dmaven.javadoc.skip=true.