Skip to content

[GH-2901]: Fix ST_BestSRID logic for Geometries near the poles#2902

Merged
jiayuasu merged 5 commits intoapache:masterfrom
ThomasDekeyser:master
May 6, 2026
Merged

[GH-2901]: Fix ST_BestSRID logic for Geometries near the poles#2902
jiayuasu merged 5 commits intoapache:masterfrom
ThomasDekeyser:master

Conversation

@ThomasDekeyser
Copy link
Copy Markdown
Contributor

@ThomasDekeyser ThomasDekeyser commented May 4, 2026

Reason: used Spheriod.angularWidth() and Spheroid.angularHeight() methods did not return a value in degrees.

Did you read the Contributor Guide?

Is this PR related to a ticket?

What changes were proposed in this PR?

Fix existing methods Spheroid.angularWidth() and Spheroid.angularHeight() to return a value in degrees.

How was this patch tested?

SpheroidTest

  • a straight line from north to south pole should return 180° in Spheroid.angularHeight()
  • a straight line from -90° Lon to +90° Lon over the equator should return 180° in Spheroid.angularWidth()

FunctionsTest

  • BestSRID for a line near south pole

Did this PR include necessary documentation updates?

  • No, this PR does not affect any public API so no need to change the documentation.

Reason: used Spheriod.angularWidth() and Spheroid.angularHeight() methods did not return a value in degrees.
@jiayuasu
Copy link
Copy Markdown
Member

jiayuasu commented May 4, 2026

@ThomasDekeyser thanks. Please fix spotless by running mvn spotless:apply

@jiayuasu jiayuasu added this to the sedona-1.9.1 milestone May 4, 2026
@jiayuasu jiayuasu requested a review from prantogg May 5, 2026 04:44
@jiayuasu
Copy link
Copy Markdown
Member

jiayuasu commented May 5, 2026

@prantogg take a look please?

Copy link
Copy Markdown
Contributor

@prantogg prantogg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good. Thanks for the bug fix @ThomasDekeyser !

@jiayuasu jiayuasu added the bug label May 6, 2026
@jiayuasu jiayuasu merged commit d451b6b into apache:master May 6, 2026
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants