[GH-2901]: Fix ST_BestSRID logic for Geometries near the poles#2902
Merged
jiayuasu merged 5 commits intoapache:masterfrom May 6, 2026
Merged
[GH-2901]: Fix ST_BestSRID logic for Geometries near the poles#2902jiayuasu merged 5 commits intoapache:masterfrom
jiayuasu merged 5 commits intoapache:masterfrom
Conversation
Reason: used Spheriod.angularWidth() and Spheroid.angularHeight() methods did not return a value in degrees.
Member
|
@ThomasDekeyser thanks. Please fix spotless by running |
Member
|
@prantogg take a look please? |
prantogg
approved these changes
May 6, 2026
Contributor
prantogg
left a comment
There was a problem hiding this comment.
Look good. Thanks for the bug fix @ThomasDekeyser !
jiayuasu
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason: used Spheriod.angularWidth() and Spheroid.angularHeight() methods did not return a value in degrees.
Did you read the Contributor Guide?
Is this PR related to a ticket?
[GH-XXX] my subject. Closes #[BUG]: ST_BestSRID is not returning Lambert Azimuthal Equal Area projection for geometries near the poles #2901What changes were proposed in this PR?
Fix existing methods Spheroid.angularWidth() and Spheroid.angularHeight() to return a value in degrees.
How was this patch tested?
SpheroidTestFunctionsTestDid this PR include necessary documentation updates?