Skip to content

[CI] Use common linters directory for .shellcheckrc config #2629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jiayuasu merged 1 commit into from
Feb 24, 2026
Merged

[CI] Use common linters directory for .shellcheckrc config #2629

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/CODEOWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,5 @@
.pre-commit-config.yaml @jbampton @jiayuasu
.prettierignore @jbampton @jiayuasu
.prettierrc @jbampton @jiayuasu
.shellcheckrc @jbampton @jiayuasu
Makefile @jbampton @jiayuasu
/.github/linters/ @jbampton @jiayuasu
0 .shellcheckrc → .github/linters/.shellcheckrc
View file
Open in desktop
File renamed without changes.
3 changes: 2 additions & 1 deletion .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,8 +250,8 @@ repos:
\.gitattributes|
\.prettierignore|
\.prettierrc|
\.shellcheckrc|
\.github/linters/\.clang-format|
\.github/linters/\.shellcheckrc|
\.github/CODEOWNERS|
.*/\.gitignore|
tools/maven/scalafmt\.conf
Expand Down Expand Up @@ -473,6 +473,7 @@ repos:
- id: shellcheck
name: run shellcheck
description: check Shell scripts with shellcheck
args: [--rcfile=.github/linters/.shellcheckrc]
- repo: https://github.com/adrienverge/yamllint
rev: v1.38.0
hooks:
Expand Down