[GH-2450] chore(geopandas): write sjoin match tests for dwithin()#2466
[GH-2450] chore(geopandas): write sjoin match tests for dwithin()#2466bunnysocks wants to merge 2 commits intoapache:masterfrom
Conversation
There was a problem hiding this comment.
Thanks for working on this. It looks like you based this branch on your previous one in #2464, so the changes in your old PR render in addition to the changes you intended. Could you remove these changes from this PR? You can either remove the old commits (and force push) or add a new commit that undos these deletions.
| import pytest | ||
| import geopandas as gpd | ||
| from shapely.geometry import Point | ||
| from sedona.geopandas import sjoin |
There was a problem hiding this comment.
| from sedona.geopandas import sjoin | |
| from sedona.spark.geopandas import sjoin |
I tried running this locally and found that there are also multiple issues with this test code (more than just this), that prevent it from running properly. Simple things like data types issues. @bunnysocks Do you need help with setting up your developer environment? You can follow these directions for setting it up, so you can test locally. Getting it working by following those instructions should work pretty smoothly. The logic this PR proposes is on the right track, but it will be very helpful for you to run the tests locally to avoid simple errors. Feel free to ping if you get stuck or need help, including with dev env setup.
e.g failed CI run
https://github.com/apache/sedona/actions/runs/18967529015/job/54243890091?pr=2466
Did you read the Contributor Guide?
Is this PR related to a ticket?
[GH-2450] chore(geopandas): write sjoin match tests for dwithin().Closes chore(geopandas): Write sjoin match tests for dwithin() #2450
What changes were proposed in this PR?
This PR adds new tests to improve coverage for Sedona’s GeoPandas integration, specifically for the
sjoin()function using thepredicate="dwithin"parameter.Key updates:
test_sjoin_match.pyundersedona/python/tests/geopandas/.sjoin()outputs fordwithin()predicate.0.5,0.05, etc.)These tests aim to ensure Sedona’s spatial join behavior matches GeoPandas’ expected results and help detect future regressions.
How was this patch tested?
pytestlocally.dwithin()joins.Did this PR include necessary documentation updates?