test: strengthen IP address utility assertions#10649
Open
Loyal-Young wants to merge 1 commit into
Open
Conversation
Loyal-Young
marked this pull request as ready for review
July 22, 2026 17:15
RockteMQ-AI
approved these changes
Jul 22, 2026
RockteMQ-AI
left a comment
Contributor
There was a problem hiding this comment.
Review by github-manager-bot
Summary
Replaces JVM assert statements with AssertJ assertions in IPAddressUtilsTest, making test expectations explicit and independent of JVM assertion settings. Clean, well-scoped test improvement.
Findings
- [Info] The diff rewrites the entire file (+84/-83 on a 92-line file), which suggests a line-ending normalization (CRLF → LF) alongside the semantic changes. Consider mentioning this in the PR description or separating it into a dedicated commit to keep
git blamehistory cleaner. - [Info] Also fixes the missing newline at end of file — good cleanup.
Assessment
- All existing test expectations (IPv4, IPv6, CIDR, scope, bracketed-address) are correctly preserved
assertThat(X).isTrue()/assertThat(X).isFalse()conversions are semantically identical to the originalassert X/assert !X- AssertJ import is correctly added
- No production code changes
LGTM. Straightforward test hardening with no risk.
Automated review by github-manager-bot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
assertstatements inIPAddressUtilsTestwith AssertJ assertionsWhy
Framework assertions make each test expectation explicit and provide useful failure diagnostics without depending on JVM assertion settings.
Impact
Production code is unchanged. The existing IP address utility coverage becomes more robust and easier to diagnose when it fails.
Validation
git diff --checkmvn --batch-mode --no-transfer-progress -pl common -Djacoco.skip=true -Dtest=IPAddressUtilsTest test