Skip to content

[refactor] Use isEmpty() in TransactionalMessageServiceImpl #10131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Senrian wants to merge 1 commit into from
Closed

[refactor] Use isEmpty() in TransactionalMessageServiceImpl #10131

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ...in/java/org/apache/rocketmq/broker/transaction/queue/TransactionalMessageServiceImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ public void check(long transactionTimeout, int transactionCheckMax,
try {
String topic = TopicValidator.RMQ_SYS_TRANS_HALF_TOPIC;
Set<MessageQueue> msgQueues = transactionalMessageBridge.fetchMessageQueues(topic);
if (msgQueues == null || msgQueues.size() == 0) {
if (msgQueues == null || msgQueues.isEmpty()) {
log.warn("The queue of topic is empty :" + topic);
return;
}
Expand Down Expand Up @@ -425,7 +425,7 @@ private PullResult fillOpRemoveMap(HashMap<Long, Long> removeMap, MessageQueue o
log.error("Found a illegal tag in opMessageExt= {} ", opMessageExt);
}

if (set.size() > 0) {
if (!set.isEmpty()) {
opMsgMap.put(opMessageExt.getQueueOffset(), set);
} else {
doneOpOffset.add(opMessageExt.getQueueOffset());
Expand Down Expand Up @@ -572,7 +572,7 @@ private GetResult getHalfMsg(MessageQueue messageQueue, long offset) {
if (result != null) {
getResult.setPullResult(result);
List<MessageExt> messageExts = result.getMsgFoundList();
if (messageExts == null || messageExts.size() == 0) {
if (messageExts == null || messageExts.isEmpty()) {
return getResult;
}
getResult.setMsg(messageExts.get(0));
Expand Down