fix(pulsar): pass webServiceTlsCiphers to Jetty factory - #26423
Open
shoemoney wants to merge 1 commit into
Open
Conversation
Fix verified RED->GREEN. Broker WebService and proxy lookup leg silently ignore TLS cipher/protocol restrictions at WebService.java:608
lhotari
requested changes
Aug 26, 2026
lhotari
left a comment
Member
There was a problem hiding this comment.
Thanks for the PR. There's currently PIP-478 implementation PRs in progress for the master branch which will cover this gap. Please target branch-4.2 with this change (rebase your PR branch on top of origin/branch-4.2 and update the target branch for this PR to apache:branch-4.2).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes silent ignore of TLS cipher and protocol restrictions in the broker WebService and proxy lookup leg.
Motivation: WebService.java:608 passes getTlsCiphers/getTlsProtocols to the Jetty factory, ignoring webServiceTlsCiphers/webServiceTlsProtocols. ProxyConnection.createClientConfiguration omits ciphers/protocols entirely for the broker lookup client.
Modifications:
Fix verified RED to GREEN. No unrelated formatting.