Skip to content

fix(pulsar): pass webServiceTlsCiphers to Jetty factory - #26423

Open
shoemoney wants to merge 1 commit into
apache:masterfrom
shoemoney:fix/pulsar-tls-cipher
Open

fix(pulsar): pass webServiceTlsCiphers to Jetty factory#26423
shoemoney wants to merge 1 commit into
apache:masterfrom
shoemoney:fix/pulsar-tls-cipher

Conversation

@shoemoney

Copy link
Copy Markdown

Fixes silent ignore of TLS cipher and protocol restrictions in the broker WebService and proxy lookup leg.

Motivation: WebService.java:608 passes getTlsCiphers/getTlsProtocols to the Jetty factory, ignoring webServiceTlsCiphers/webServiceTlsProtocols. ProxyConnection.createClientConfiguration omits ciphers/protocols entirely for the broker lookup client.

Modifications:

  • WebService: use firstNonEmpty(getWebServiceTlsCiphers, getTlsCiphers) and same for protocols with fallback, mirroring DefaultBrokerTlsFactory.webPolicy
  • ProxyConnection: propagate brokerClientTlsCiphers/brokerClientTlsProtocols to ClientConfigurationData for the lookup leg

Fix verified RED to GREEN. No unrelated formatting.

Fix verified RED->GREEN. Broker WebService and proxy lookup leg silently ignore TLS cipher/protocol restrictions at WebService.java:608

@lhotari lhotari left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. There's currently PIP-478 implementation PRs in progress for the master branch which will cover this gap. Please target branch-4.2 with this change (rebase your PR branch on top of origin/branch-4.2 and update the target branch for this PR to apache:branch-4.2).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants