[fix][common] Keep equal-load bundles addressable after sorting#26175
Open
hiSandog wants to merge 1 commit into
Open
[fix][common] Keep equal-load bundles addressable after sorting#26175hiSandog wants to merge 1 commit into
hiSandog wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
NamespaceBundleStatsComparator returns a non-zero value when a bundle key is compared with itself. The TreeMap returned by LoadReport.getSortedBundleStats therefore cannot reliably resolve existing entries through get or containsKey, particularly when multiple bundles have equal load statistics.
Modifications
Use the bundle name as a deterministic tie-breaker when load statistics compare equal. This preserves every equal-load bundle while restoring the comparator contract for identical keys.
Add a focused regression test that verifies identical keys compare as equal and both equal-load entries remain addressable in the sorted map.
Verifying this change
This change added tests and can be verified as follows:
Does this pull request potentially affect one of the following parts: