[improve][broker] Trace the asynchronous tasks in logs when loading topics#26163
Open
BewareMyPower wants to merge 3 commits into
Open
[improve][broker] Trace the asynchronous tasks in logs when loading topics#26163BewareMyPower wants to merge 3 commits into
BewareMyPower wants to merge 3 commits into
Conversation
0cf2bee to
7ed63b7
Compare
dao-jun
approved these changes
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The topic loading time could be high with pressure, but it's hard to measure which sub-task takes the most time. This is a follow-up work of #24785 to improve the logs that show topic loading latency.
Modifications
Add a simple tracing class
LatencyTracerand trace asynchronous futures during topic loading. When tracing a future, if the future is already done, skip tracing it because such tasks are usually not CPU-bounded.Verifying this change
LatencyTracerTestcovers functionality of all public methods with injected timestamps. The topic loading logs can be checked by runningtestConcurrentLoadTopicExceedLimitShouldNotBeAutoCreated:Out of scope
In my previous tests, opening managed ledger could also take much time, this
LatencyTracerclass can be used to track managed ledger open process as well.