[fix][build] Restore Maven-era async-profiler wiring for integration test images#26147
Open
void-ptr974 wants to merge 1 commit into
Open
[fix][build] Restore Maven-era async-profiler wiring for integration test images#26147void-ptr974 wants to merge 1 commit into
void-ptr974 wants to merge 1 commit into
Conversation
6a1934f to
e7ceff2
Compare
Member
async-profiler should be upgraded to 4.4 version |
e7ceff2 to
a3973be
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
PulsarProfilingTestsupports profiling broker-side workloads with async-profiler. This support existed in the Maven-based workflow, where the build could install async-profiler into the test images and pass the profiler options to the integration test JVM.After the Gradle migration, the same async-profiler wiring was no longer available through the Gradle build. This PR backports the Maven-era async-profiler wiring to Gradle. It does not introduce a new profiling mode; it restores the existing profiling workflow for the Gradle build.
Modifications
docker.install.asyncprofileroption to:tests:java-test-image:dockerBuild.docker.install.asyncprofileroption to:tests:latest-version-image:dockerBuild.integrationTestJVM:inttest.asyncprofiler.dirinttest.asyncprofiler.optsinttest.asyncprofiler.outputformatgit.commit.id.abbrevbuild.timestampPulsarContainerdefaults for optional profiler settings when the matching Gradle properties are not provided.PulsarProfilingTestusage comments to use the Gradle Docker image build task and--tests.Usage
Build the test image with async-profiler installed:
Run the profiling integration test:
The profiler output is written to the directory configured by
inttest.asyncprofiler.dir.Verifying this change
This change can be verified with the existing profiling integration test workflow:
./gradlew :tests:integration:compileTestJava :tests:integration:checkstyleTest --no-configuration-cache./gradlew :tests:java-test-image:dockerBuild -Pdocker.install.asyncprofiler=true -Pdocker.wolfi./gradlew :tests:latest-version-image:dockerBuild -Pdocker.install.asyncprofiler=true -Pdocker.wolfiintegrationTestJVM.PulsarProfilingTest.runPulsarPerfpasses withENABLE_MANUAL_TEST=true.-agentpathoption..jfrfile readable byjfr summary.Does this pull request potentially affect one of the following parts: