[fix][client] Fix idle connection release ignoring V5 watch sessions#25697
Merged
lhotari merged 1 commit intoapache:masterfrom May 6, 2026
Merged
[fix][client] Fix idle connection release ignoring V5 watch sessions#25697lhotari merged 1 commit intoapache:masterfrom
lhotari merged 1 commit intoapache:masterfrom
Conversation
Signed-off-by: Dream95 <zhou_8621@163.com>
lhotari
approved these changes
May 6, 2026
Contributor
Author
|
/pulsarbot rerun-failure-checks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
When connectionMaxIdleSeconds is enabled, ConnectionPool periodically calls ClientCnxIdleState#doIdleDetect, which uses ClientCnx#idleCheck() to decide whether a pooled connection is idle. idleCheck() did not account for V5 registrations (dagWatchSessions, scalableConsumerSessions, scalableTopicsWatchers), while channelInactive treats them as live sessions on the connection. As a result, connections that still served scalable-topic watches or DAG watches could be marked idle and released, causing unnecessary disconnects and other errors.
Modifications
Added checks in ClientCnx#idleCheck() for dagWatchSessions, scalableConsumerSessions, and scalableTopicsWatchers
Verifying this change
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Matching PR in forked repository
PR in forked repository: Dream95#7