[Bug fix] Skip flushing empty chunk in OffHeapH3IndexCreator#18834
Open
J-HowHuang wants to merge 3 commits into
Open
[Bug fix] Skip flushing empty chunk in OffHeapH3IndexCreator#18834J-HowHuang wants to merge 3 commits into
J-HowHuang wants to merge 3 commits into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #18834 +/- ##
============================================
- Coverage 64.78% 64.77% -0.01%
- Complexity 1309 1319 +10
============================================
Files 3381 3392 +11
Lines 209967 210989 +1022
Branches 32891 33128 +237
============================================
+ Hits 136020 136664 +644
- Misses 62979 63301 +322
- Partials 10968 11024 +56
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Jackie-Jiang
added
bug
Jackie-Jiang
approved these changes
Jun 22, 2026
xiangfu0
approved these changes
Jun 22, 2026
|
|
||
| // Flush the last chunk | ||
| if (_postingListMap.size() % FLUSH_THRESHOLD != 0) { | ||
| if (!_postingListMap.isEmpty() && _postingListMap.size() % FLUSH_THRESHOLD != 0) { |
Contributor
There was a problem hiding this comment.
(minor) This is actually redundant. Actually it might be more clear to only check whether map is empty
Suggested change
| if (!_postingListMap.isEmpty() && _postingListMap.size() % FLUSH_THRESHOLD != 0) { | |
| if (!_postingListMap.isEmpty()) { |
Collaborator
Author
There was a problem hiding this comment.
oh yeah this one is a different check. thanks for pointing out
| if (_postingListMap.size() % FLUSH_THRESHOLD == 0) { | ||
| // Skip flushing an empty posting list map. This could happen when add() didn't add any entry due to invalid | ||
| // Geometry and _continueOnError is set | ||
| if (!_postingListMap.isEmpty() && _postingListMap.size() % FLUSH_THRESHOLD == 0) { |
Contributor
There was a problem hiding this comment.
Should we simply do:
Suggested change
| if (!_postingListMap.isEmpty() && _postingListMap.size() % FLUSH_THRESHOLD == 0) { | |
| if (_postingListMap.size() == FLUSH_THRESHOLD) { |
Collaborator
Author
There was a problem hiding this comment.
makes sense, add() always only adds one entry at a time
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Desciption
H3 index could run into
java.lang.IndexOutOfBoundsExceptionbecause empty chunk could be added into the chunk list. An empty chunk would cause out of bound read in
ChunkIteratorChange
Test
Added an unit test and verified it would fail without the patch