Adding new API to register backward compatible class names#17772
Merged
Adding new API to register backward compatible class names#17772
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an API on PluginManager to register mappings from deprecated plugin class names to their modern replacements, enabling backward compatibility during plugin/library migrations.
Changes:
- Introduced
registerBackwardCompatibleClassName(oldClassName, newClassName)to store deprecated→new class name mappings. - Added an inline comment describing the method’s intent.
pinot-spi/src/main/java/org/apache/pinot/spi/plugin/PluginManager.java
Outdated
Show resolved
Hide resolved
f5c009b to
4d0e628
Compare
❌ 2 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
Jackie-Jiang
approved these changes
Feb 27, 2026
pinot-spi/src/main/java/org/apache/pinot/spi/plugin/PluginManager.java
Outdated
Show resolved
Hide resolved
pinot-spi/src/main/java/org/apache/pinot/spi/plugin/PluginManager.java
Outdated
Show resolved
Hide resolved
9aman
approved these changes
Feb 27, 2026
pinot-spi/src/main/java/org/apache/pinot/spi/plugin/PluginManager.java
Outdated
Show resolved
Hide resolved
4d0e628 to
c9cf20e
Compare
xiangfu0
added a commit
to xiangfu0/pinot
that referenced
this pull request
Feb 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new method to the
PluginManagerclass to support backward compatibility for plugin class names. This allows users to register mappings from deprecated class names to their new equivalents, helping maintain compatibility when plugins or libraries are updated.Backward compatibility support:
registerBackwardCompatibleClassNamemethod toPluginManagerthat lets users map old plugin class names to new ones for smoother deprecation and migration processes.