Skip to content

Adding new API to register backward compatible class names#17772

Merged
xiangfu0 merged 1 commit intomasterfrom
allow-register-backward-compatible-class-mapping
Feb 28, 2026
Merged

Adding new API to register backward compatible class names#17772
xiangfu0 merged 1 commit intomasterfrom
allow-register-backward-compatible-class-mapping

Conversation

@xiangfu0
Copy link
Contributor

This pull request introduces a new method to the PluginManager class to support backward compatibility for plugin class names. This allows users to register mappings from deprecated class names to their new equivalents, helping maintain compatibility when plugins or libraries are updated.

Backward compatibility support:

  • Added a registerBackwardCompatibleClassName method to PluginManager that lets users map old plugin class names to new ones for smoother deprecation and migration processes.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds an API on PluginManager to register mappings from deprecated plugin class names to their modern replacements, enabling backward compatibility during plugin/library migrations.

Changes:

  • Introduced registerBackwardCompatibleClassName(oldClassName, newClassName) to store deprecated→new class name mappings.
  • Added an inline comment describing the method’s intent.

@xiangfu0 xiangfu0 force-pushed the allow-register-backward-compatible-class-mapping branch from f5c009b to 4d0e628 Compare February 26, 2026 08:56
@codecov-commenter
Copy link

codecov-commenter commented Feb 26, 2026

❌ 2 Tests Failed:

Tests completed Failed Passed Skipped
10884 2 10882 52
View the top 3 failed test(s) by shortest run time
org.apache.pinot.controller.helix.core.minion.PinotTaskManagerDistributedLockingTest::testForceReleaseLockDuringTaskExecution
Stack Traces | 18.8s run time
Both createTask calls should have generated tasks expected [2] but found [3]
org.apache.pinot.controller.helix.core.minion.PinotTaskManagerDistributedLockingTest::testForceReleaseLockDuringTaskExecution
Stack Traces | 21.1s run time
Both createTask calls should have generated tasks expected [2] but found [3]
org.apache.pinot.integration.tests.TableRebalancePauselessIntegrationTest::setUp
Stack Traces | 126s run time
Failed to start Kafka cluster after 3 attempts
org.apache.pinot.integration.tests.TableRebalancePauselessIntegrationTest::testForceCommit
Stack Traces | 126s run time
java.lang.AssertionError: expected object to not be null

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

Copy link
Contributor

@9aman 9aman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xiangfu0 xiangfu0 force-pushed the allow-register-backward-compatible-class-mapping branch from 4d0e628 to c9cf20e Compare February 27, 2026 21:45
@xiangfu0 xiangfu0 merged commit 337faad into master Feb 28, 2026
14 of 16 checks passed
@xiangfu0 xiangfu0 deleted the allow-register-backward-compatible-class-mapping branch February 28, 2026 00:01
xiangfu0 added a commit to xiangfu0/pinot that referenced this pull request Feb 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants