PHOENIX-7848. Use ZK TLS properties from HBase config if present#2467
Open
anmolnar wants to merge 3 commits into
Open
PHOENIX-7848. Use ZK TLS properties from HBase config if present#2467anmolnar wants to merge 3 commits into
anmolnar wants to merge 3 commits into
Conversation
richardantal
requested changes
May 12, 2026
Contributor
Author
|
@richardantal I moved I'm not sure about the exception handler. What should be the logic inside the exception handler? I don't want the error to be swallowed and ignored, because if there's anything wrong with the configuration, the tool should refuse to work. |
richardantal
approved these changes
May 14, 2026
Contributor
richardantal
left a comment
richardantal
left a comment
There was a problem hiding this comment.
LGTM
Thanks Andor for this change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Parse ZooKeeper TLS properties from
hbase-site.xmland add them tosqllinecommand line args.Why are the changes needed?
Phoenix
sqllinethick client is unable to connect to TLS-only ZooKeeper ensemble.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Locally.
Was this patch authored or co-authored using generative AI tooling?
No.