fix: validate legal files in packaged jars#3328
Open
He-Pin wants to merge 1 commit into
Open
Conversation
Motivation: Published jars can silently omit required META-INF legal files, and the protobuf-v3 assembly needs explicit merge handling. Modification: Merge legal resources in the protobuf-v3 assembly and add a validation task for every published project. Result: Published package and assembly jars are checked for META-INF/LICENSE and META-INF/NOTICE. Tests: - sbt "actor / Compile / checkPackageBinMetaInfLegalFiles" "protobuf-v3 / Compile / checkPackageBinMetaInfLegalFiles" (pass) - sbt headerCreateAll "+headerCheckAll" scalafmtCheckAll scalafmtSbtCheck (pass) - scalafmt --list --mode diff-ref=origin/main (pass) - git diff --check (pass) - validatePullRequest not run per user request References: Fixes #1470
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Published jars can silently omit required
META-INF/LICENSEandMETA-INF/NOTICEfiles. Theprotobuf-v3assembly also needs explicit merge handling for legal resources.Modification
protobuf-v3assembly while retaining the protobuf COPYING file.packageBinand the published artifact for required META-INF legal files.Result
Normal package jars and assembly-backed published jars fail validation when either required legal file is missing.
References
Fixes #1470