Make classic remoting handoff recovery test eventual#3318
Merged
He-Pin merged 1 commit intoJul 10, 2026
Conversation
Motivation: The passive read handoff spec observes handle disassociation before the original reader has necessarily processed ResumeReading, making its single verification message timing-dependent. Modification: Retry the verification message with awaitAssert and a bounded per-attempt timeout until the outbound reader resumes. Result: The regression test still fails when reader recovery never happens while tolerating the expected cross-actor handoff delay. Tests: - JDK 17, Scala 3.8.4 focused RemotingSpec test: passed - JDK 17, Scala 3.8.4 full RemotingSpec: 22 passed - JDK 17, Scala 2.13.18 focused RemotingSpec test: passed - sbt headerCreateAll +headerCheckAll: passed - scalafmt --list --mode diff-ref=origin/main: passed - git diff --check: passed References: Refs apache#3205
Philippus
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The regression test added by #3205 waits for the read-only handle disassociation and then sends one verification payload through the original association. Those events are processed by different actors, so the original EndpointReader may still be in its not-reading state and discard that payload before it processes ResumeReading.
This race surfaced in CI while validating #3300, but it is independent of that PR changes.
Modification
Wrap the final verification write and expectation in awaitAssert, with a bounded 500 ms wait per attempt. The existing default overall assertion timeout remains unchanged.
Result
The test tolerates the expected asynchronous handoff completion while still failing if the original reader never resumes and delivers a verification message.
Tests
References
Refs #3205