ddata: Add wildcard prefix subscriptions to Replicator#2735
Draft
pjfanning wants to merge 4 commits intoapache:mainfrom
Draft
ddata: Add wildcard prefix subscriptions to Replicator#2735pjfanning wants to merge 4 commits intoapache:mainfrom
pjfanning wants to merge 4 commits intoapache:mainfrom
Conversation
…akka-core#31731) Co-authored-by: pjfanning <11783444+pjfanning@users.noreply.github.com>
* Initial plan * Add wildcard subscription improvements: override withId, serialization, docs, and tests Co-authored-by: pjfanning <11783444+pjfanning@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: pjfanning <11783444+pjfanning@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port of akka/akka-core#31731. Adds support for subscribing to all keys matching a given prefix by using
*at the end of the key id. New and existing matching keys both trigger notifications.part of #2730
KeyUnspecificKey— a genericKey[ReplicatedData]used to represent matched wildcard keys in notificationswithId(newId)toKeyabstract class, used internally to construct a concrete key instance for each matched wildcard keyReplicatorwildcardSubscribersMultiMap (keyed by prefix, i.e. id with*stripped)isWildcard/dropWildcardhelpers; applied these consistently to existingdurable/durableWildcardslogic tooreceiveFlushChanges: wildcard subscribers are notified for changed keys; new wildcard subscriptions receive current values for all existing matching keysreceiveUnsubscribe/receiveTerminated: clean upwildcardSubscriberscorrectlyhasSubscriber(keyId)/getSubscribersIterator(keyId): new private methods combining direct and wildcard subscriber lookupUsage