Open
Conversation
Member
|
I'm not 100% in favour of this. pekko-grpc is pretty complicated to use - this class is somewhat easier to use. |
Member
Author
|
But seems this will not provide more function than it is now, but with grpc, a user can easy to write an Cluster endpoint. |
Member
|
Unless we can document how users are meant to use pekko-grpc in detail, I would favour not deleting this code - even possibly undeprecating it. |
Member
Author
|
Just a gRPC server which receive the message and then forwarding to the cluster:) |
Member
That is much more complicated than us providing a ClusterClient. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
The Cluster client is deprecated since Akka 2.6.0 and suggests using Pekko Grpc instead.
Modification:
Delete Cluster client code and doc.
Result:
Clean code.