Upgrade Avro dependency from 1.11.5 to 1.12.2 - #3731
Open
iemejia wants to merge 1 commit into
Open
Conversation
- Guard against null logicalType in AvroRecordConverter.newConverter to avoid NPE in GenericData.getConversionByClass (Avro 1.12 no longer null-checks logicalType internally) - Create typed arrays instead of Object[] in AvroArrayConverter.end to satisfy Avro 1.12's stricter ReflectData.setField type checks - Add SERIALIZABLE_PACKAGES surefire property for Avro 1.12's ClassSecurityValidator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Upgrades the Avro dependency from 1.11.5 to 1.12.2.
Avro 1.12 introduces some behavioral and API-compatibility changes that require corresponding adjustments in
parquet-avro:logicalTypeNPE:GenericData.getConversionByClassno longer null-checkslogicalTypeinternally, soAvroRecordConverter.newConverternow guards against a nulllogicalTypeto avoid an NPE.ReflectData.setFieldperforms stricter type checks, soAvroArrayConverter.endnow creates a typed array (viaArray.newInstance(elementClass, 0)) instead of an untypedObject[].ClassSecurityValidatorrequires whitelisting serializable packages; theorg.apache.avro.SERIALIZABLE_PACKAGESsurefire system property is added for the tests.What changes are included in this PR?
avro.versionto1.12.2in the rootpom.xml.logicalTypeinAvroRecordConverter.newConverter.Object[]inAvroArrayConverter.end.SERIALIZABLE_PACKAGESsurefire property inparquet-avro/pom.xml.Are these changes tested?
Yes, covered by the existing
parquet-avrotest suite.Are there any user-facing changes?
Users of
parquet-avrowill now pull in Avro 1.12.2.