MINOR: Upgrade thrift to 0.24 - #3730
Open
dossett wants to merge 2 commits into
Open
Conversation
Fokko
approved these changes
Aug 18, 2026
Fokko
left a comment
Fokko
left a comment
Contributor
There was a problem hiding this comment.
LGTM, We might need something similar in parquet-format :)
| ``` | ||
| brew install thrift | ||
| export PATH="/usr/local/opt/thrift@0.23.0/bin:$PATH" | ||
| export PATH="$(brew --prefix thrift)/bin:$PATH" |
Contributor
There was a problem hiding this comment.
Unfortunally, this is an improvement since brew does not keep the old Thrift versions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was testing a PR and couldn't
brew installthrift 0.23, because only 0.24 is available. So this PR does two things:Dockerfilethat developers can use that removes the dependency on a locally installed copy of thrift (and any other dependency).I find solutions like the Dockerfile to be really useful, but if maintainers feel its not appropriate to add to the repo I would certainly understand. The part can be reverted and the thrift upgrade will work just fine.