GH-421: Clarify schema field name uniqueness - #610
Draft
d33bs wants to merge 1 commit into
Draft
Conversation
State that sibling fields in a schema group must have distinct names. Clarify that path_in_schema must identify one primitive field. Closes apache#421.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
The Parquet format did not say whether two sibling fields can have the same name. This can make
path_in_schemaambiguous, because one path can match more than one field.What changes are included in this PR?
This PR updates the Thrift schema comments to state that direct children of a group must have distinct names. Name comparison is case-sensitive.
It also clarifies that
path_in_schemamust identify exactly one primitive field.Do these changes have PoC implementations?
No. This is a specification clarification only.
Closes #421