[common] Fix SliceComparator on BINARY and VARBINARY fields (#8873) - #8874
Open
jordepic wants to merge 1 commit into
Open
[common] Fix SliceComparator on BINARY and VARBINARY fields (#8873)#8874jordepic wants to merge 1 commit into
jordepic wants to merge 1 commit into
Conversation
Contributor
Author
|
cc @JingsongLi — legal binary primary keys crash the sorted lookup store's comparator the first time lookup compaction probes a higher level; the fix reuses SortUtil.compareBinary so lookup files order the same way BinaryRow does. |
) TypeCheckUtils.isComparable admits BINARY and VARBINARY, and primary keys may contain them, but SliceComparator cast every field value to Comparable — byte[] is not, so any sorted-lookup-store comparison over a binary key field (lookup compaction, deletion-vector maintenance, lookup changelog producer) threw ClassCastException. Compare binary fields with SortUtil.compareBinary, the same unsigned lexicographic order BinaryRow uses.
jordepic
force-pushed
the
fix-binary-pk-slice-comparator
branch
from
July 27, 2026 21:02
b4e55ea to
c04ae03
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fixes #8873.
TypeCheckUtils.isComparableadmits BINARY and VARBINARY, and primary keys may contain them, butSliceComparatorcast every field value toComparable—byte[]is not, so any sorted-lookup-store seek over a binary key field (lookup compaction, deletion-vector maintenance, lookup changelog producer) threwClassCastException. Compare binary fields withSortUtil.compareBinary, the same unsigned lexicographic orderBinaryRowuses, so lookup files order consistently with the rest of the merge tree.Tests
RowCompactedSerializerTest.BinaryFieldTest: serializer round-trips over an(INT, BYTES)row type plus a slice-comparator test covering less/greater/equal and the unsigned edge (0xFForders above0x01).API and Format
No changes.
Documentation
No changes.