-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[core] Support LocalKvDb merge and TTL compaction #8872
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
JingsongLi
wants to merge
1
commit into
apache:master
Choose a base branch
from
JingsongLi:codex/local-kv-merge-ttl-compaction
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
97 changes: 97 additions & 0 deletions
97
paimon-common/src/main/java/org/apache/paimon/lookup/sort/db/RecordCombiningWriter.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,97 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.paimon.lookup.sort.db; | ||
|
|
||
| import org.apache.paimon.memory.MemorySlice; | ||
|
|
||
| import javax.annotation.Nullable; | ||
|
|
||
| import java.io.IOException; | ||
| import java.util.ArrayList; | ||
| import java.util.List; | ||
|
|
||
| import static org.apache.paimon.lookup.sort.db.LocalKvDb.isTombstone; | ||
|
|
||
| /** Combines adjacent records before forwarding them to an SST writer. */ | ||
| final class RecordCombiningWriter { | ||
|
|
||
| @Nullable private final LocalKvDb.MergeOperator mergeOperator; | ||
| private final RecordConsumer consumer; | ||
|
|
||
| @Nullable private MemorySlice pendingKey; | ||
| private final List<byte[]> pendingValues; | ||
|
|
||
| RecordCombiningWriter( | ||
| @Nullable LocalKvDb.MergeOperator mergeOperator, RecordConsumer consumer) { | ||
| this.mergeOperator = mergeOperator; | ||
| this.consumer = consumer; | ||
| this.pendingValues = new ArrayList<>(); | ||
| } | ||
|
|
||
| void put(MemorySlice key, byte[] value) throws IOException { | ||
| if (mergeOperator == null) { | ||
| consumer.accept(key, value); | ||
| return; | ||
| } | ||
|
|
||
| if (isTombstone(value)) { | ||
| flushPending(); | ||
| consumer.accept(key, value); | ||
| return; | ||
| } | ||
|
|
||
| if (pendingKey == null) { | ||
| startGroup(key, value); | ||
| } else if (mergeOperator.canMerge(pendingKey, key)) { | ||
| pendingValues.add(value); | ||
| } else { | ||
| flushPending(); | ||
| startGroup(key, value); | ||
| } | ||
| } | ||
|
|
||
| void finish() throws IOException { | ||
| flushPending(); | ||
| } | ||
|
|
||
| private void startGroup(MemorySlice key, byte[] value) { | ||
| pendingKey = MemorySlice.wrap(key.copyBytes()); | ||
| pendingValues.add(value); | ||
| } | ||
|
|
||
| private void flushPending() throws IOException { | ||
| if (pendingKey == null) { | ||
| return; | ||
| } | ||
|
|
||
| byte[] value = | ||
| pendingValues.size() == 1 | ||
| ? pendingValues.get(0) | ||
| : mergeOperator.merge(pendingValues); | ||
| consumer.accept(pendingKey, value); | ||
| pendingKey = null; | ||
| pendingValues.clear(); | ||
| } | ||
|
|
||
| /** Callback receiving one combined record. */ | ||
| interface RecordConsumer { | ||
|
|
||
| void accept(MemorySlice key, byte[] value) throws IOException; | ||
| } | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RecordCombiningWritercan collapse multiple keys into the first key without writing tombstones for the consumed keys. If an older run still contains one of those keys (for example frombulkLoad), reads fall through to the stale value after flush. I reproduced this with olda-1/a-2, then newa-1/a-2:get(a-2)returnsnew-2before flush andold-2after flush. Partial compaction has the same risk when older runs remain. Please ensure every consumed key shadows older versions, or restrict combining to cases where no older run can remain, and add a regression test.