Skip to content

[core] Optimize ZSTD block decompression #8865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JingsongLi merged 1 commit into from
Jul 28, 2026
+15 −23
Merged

[core] Optimize ZSTD block decompression #8865

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 15 additions & 23 deletions paimon-common/src/main/java/org/apache/paimon/compression/ZstdBlockDecompressor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,37 +18,29 @@

package org.apache.paimon.compression;

import com.github.luben.zstd.RecyclingBufferPool;
import com.github.luben.zstd.ZstdInputStream;

import java.io.ByteArrayInputStream;
import java.io.IOException;
import com.github.luben.zstd.Zstd;
import com.github.luben.zstd.ZstdException;

/** A {@link BlockDecompressor} for zstd. */
public class ZstdBlockDecompressor implements BlockDecompressor {

@Override
public int decompress(byte[] src, int srcOff, int srcLen, byte[] dst, int dstOff)
throws BufferDecompressionException {
ByteArrayInputStream inputStream = new ByteArrayInputStream(src, srcOff, srcLen);
try (ZstdInputStream decompressorStream =
new ZstdInputStream(inputStream, RecyclingBufferPool.INSTANCE)) {
int decompressedLen = 0;
while (true) {
int offset = dstOff + decompressedLen;
int count = decompressorStream.read(dst, offset, dst.length - offset);
if (count <= 0) {
if (decompressorStream.available() != 0) {
throw new BufferDecompressionException(
"Dst is too small and the decompression was not completed.");
}
break;
}
decompressedLen += count;
}
return decompressedLen;
} catch (IOException e) {
long decompressedLen;
try {
decompressedLen =
Zstd.decompressByteArray(dst, dstOff, dst.length - dstOff, src, srcOff, srcLen);
} catch (ZstdException e) {
throw new BufferDecompressionException(e);
}
if (Zstd.isError(decompressedLen)) {
throw new BufferDecompressionException(Zstd.getErrorName(decompressedLen));
}
if (decompressedLen > Integer.MAX_VALUE) {
throw new BufferDecompressionException(
"Decompressed ZSTD block is too large: " + decompressedLen);
}
return (int) decompressedLen;
}
}
Loading