[python] Support row-count based file rolling for data-evolution append tables#8863
Open
XiaoHongbo-Hope wants to merge 5 commits into
Open
[python] Support row-count based file rolling for data-evolution append tables#8863XiaoHongbo-Hope wants to merge 5 commits into
XiaoHongbo-Hope wants to merge 5 commits into
Conversation
XiaoHongbo-Hope
marked this pull request as ready for review
July 27, 2026 13:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
#8739 added row-count based data file rolling (
target-file-row-num) on the core side. PyPaimon file-store writers previously did not support it and failed fast whenever the option was enabled.This PR implements
target-file-row-numrolling for data-evolution append tables in PyPaimon.Changes
DataWriter._check_and_roll_if_needed: roll a file when it reachestarget-file-row-numrows ortarget-file-size, whichever comes first (exact slicing, mirroring the format-table path). Defaults to the max long (disabled), so size-based rolling is unchanged when the option is unset.FileStoreWrite._create_data_writer: narrow the fail-fast so the option is permitted only for data-evolution append tables (i.e.AppendOnlyDataWriter— not primary-key, blob or vector writers, which override rolling and remain unsupported for now).Tests
data_evolution_row_rolling_test.py: