-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[core][flink] Support parallelism snapshot expire #7027
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
wzhero1
wants to merge
1
commit into
apache:master
Choose a base branch
from
wzhero1:feat/paimon-expire-snapshot-parallel-opt
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+2,307
−362
Draft
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
126 changes: 126 additions & 0 deletions
126
paimon-core/src/main/java/org/apache/paimon/operation/expire/DeletionReport.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,126 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.paimon.operation.expire; | ||
|
|
||
| import org.apache.paimon.data.BinaryRow; | ||
|
|
||
| import java.io.Serializable; | ||
| import java.util.HashMap; | ||
| import java.util.Map; | ||
| import java.util.Set; | ||
|
|
||
| /** Report of a single snapshot expiration task. */ | ||
| public class DeletionReport implements Serializable { | ||
|
|
||
| private static final long serialVersionUID = 1L; | ||
|
|
||
| private final long snapshotId; | ||
|
|
||
| /** Whether this task was skipped (e.g., snapshot already deleted). */ | ||
| private boolean skipped; | ||
|
|
||
| /** Whether data files were deleted. */ | ||
| private boolean dataFilesDeleted; | ||
|
|
||
| /** Whether changelog data files were deleted. */ | ||
| private boolean changelogDeleted; | ||
|
|
||
| /** Whether manifest files were deleted. */ | ||
| private boolean manifestsDeleted; | ||
|
|
||
| /** Whether snapshot metadata file was deleted. */ | ||
| private boolean snapshotDeleted; | ||
|
|
||
| /** Buckets that had files deleted (for empty directory cleanup in parallel phase). */ | ||
| private Map<BinaryRow, Set<Integer>> deletionBuckets; | ||
|
|
||
| public DeletionReport(long snapshotId) { | ||
| this.snapshotId = snapshotId; | ||
| this.skipped = false; | ||
| this.dataFilesDeleted = false; | ||
| this.changelogDeleted = false; | ||
| this.manifestsDeleted = false; | ||
| this.snapshotDeleted = false; | ||
| this.deletionBuckets = new HashMap<>(); | ||
| } | ||
|
|
||
| /** | ||
| * Create a skipped report for a snapshot that was already deleted. | ||
| * | ||
| * @param snapshotId the snapshot ID | ||
| * @return a skipped deletion report | ||
| */ | ||
| public static DeletionReport skipped(long snapshotId) { | ||
| DeletionReport report = new DeletionReport(snapshotId); | ||
| report.skipped = true; | ||
| return report; | ||
| } | ||
|
|
||
| public long snapshotId() { | ||
| return snapshotId; | ||
| } | ||
|
|
||
| public boolean isSkipped() { | ||
| return skipped; | ||
| } | ||
|
|
||
| public void setDataFilesDeleted(boolean dataFilesDeleted) { | ||
| this.dataFilesDeleted = dataFilesDeleted; | ||
| } | ||
|
|
||
| public void setChangelogDeleted(boolean changelogDeleted) { | ||
| this.changelogDeleted = changelogDeleted; | ||
| } | ||
|
|
||
| public void setManifestsDeleted(boolean manifestsDeleted) { | ||
| this.manifestsDeleted = manifestsDeleted; | ||
| } | ||
|
|
||
| public void setSnapshotDeleted(boolean snapshotDeleted) { | ||
| this.snapshotDeleted = snapshotDeleted; | ||
| } | ||
|
|
||
| public void setDeletionBuckets(Map<BinaryRow, Set<Integer>> deletionBuckets) { | ||
| this.deletionBuckets = deletionBuckets; | ||
| } | ||
|
|
||
| public Map<BinaryRow, Set<Integer>> deletionBuckets() { | ||
| return deletionBuckets; | ||
| } | ||
|
|
||
| @Override | ||
| public String toString() { | ||
| return "DeletionReport{" | ||
| + "snapshotId=" | ||
| + snapshotId | ||
| + ", skipped=" | ||
| + skipped | ||
| + ", dataFilesDeleted=" | ||
| + dataFilesDeleted | ||
| + ", changelogDeleted=" | ||
| + changelogDeleted | ||
| + ", manifestsDeleted=" | ||
| + manifestsDeleted | ||
| + ", snapshotDeleted=" | ||
| + snapshotDeleted | ||
| + ", deletionBucketsCount=" | ||
| + deletionBuckets.size() | ||
| + '}'; | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems that these fields are only updated, but unused except in
toStringmethod.