[WIP] ivfpq: Reuse list tables in batch search - #65
Open
shyjsarah wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reuse batch-local IVF-PQ list tables when many queries probe the same lists. The optimization applies to both filtered and unfiltered batch search and now exposes
off,on, andautoruntime modes. The default isauto.This PR is stacked on #64. Until #64 merges, GitHub also shows the filter-scanning commit.
Changes
IvfPqBatchTableReuseModewith:off: always use the direct residual-table path.on: force batch-local table reuse when the metric/layout prerequisites hold.auto: require the existing batch-size and probe-reuse cost heuristic.auto.VectorSearchParams.withIvfPqBatchTableReuse(...)overloads for enum and string values.Testing
cargo fmt --all -- --checkcargo clippy --workspace --all-targets --locked -- -D warningscargo test --workspace --lockedmvn -f java/pom.xml testoff, forcedon, automatic activation, and automatic fallback cases.Notes
vector_searchoption wiring is being kept in a separate local change and is not part of this PR.