fix(datafusion): apply dynamic options to vector search - #623
Open
shyjsarah wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #622
SQLContextapplies session-scoped Paimon dynamic options to ordinary table scans, but the automatically registeredvector_searchfunction loaded its table directly from the raw catalog. This caused supported read options such asblob-as-descriptorto be ignored when vector-search results were materialized.Brief change log
DynamicOptionsinstance whenSQLContextregistersvector_searchregister_vector_searchandVectorSearchFunction::newAPIs by using empty options thereblob-as-descriptorpropagation and time-travel-option exclusionTests
cargo fmt --all -- --checkcargo check -p paimon-datafusion --all-featurescargo clippy -p paimon-datafusion --all-features --lib --tests --no-deps -- -D warningscargo test -p paimon-datafusion test_vector_search_applies_supported_session_dynamic_options --libcargo test -p paimon-datafusion --test read_tables vector_search_tests::test_vector_search_java_vindex_tableThe full
paimon-datafusion --librun completed 311 tests successfully; 7 existing warehouse-fixture tests failed because the localPAIMON_TEST_WAREHOUSEdid not containpartitioned_log_table/multi_partitioned_log_table.API and Format
No public API or storage-format changes.
Documentation
No documentation changes are required; this makes
vector_searchhonor supported session read options without implying time-travel support.