fix: keep Vortex runtime alive during async IO#375
Merged
Conversation
Signed-off-by: QuakeWang <wangfuzheng0814@foxmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fixes the Ubuntu unit test hang in Vortex format tests.
The previous code used
VortexSession::default()directly. In Vortex 0.68, runtime handles are weak references to the underlying executor, so async read/write work can outlive the temporary runtime handle owner and stall when Vortex later spawns background IO tasks.Brief change log
Tests
cargo fmt --all -- --checkgit diff --checkcargo clippy --all-targets --workspace --features fulltext,vortex -- -D warningscargo test -p paimon --all-targets --features fulltext,vortexAPI and Format
No API or storage format changes.
Documentation
No documentation update required.