feat: add table update to write builder#372
Open
QuakeWang wants to merge 1 commit into
Open
Conversation
Signed-off-by: QuakeWang <wangfuzheng0814@foxmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: Part of #232
DataEvolutionWriterwas exposed as a lower-level writer and DataFusion DML created it directly, whileWriteBuilderonly covered write and commit construction. This made the table-level write API incomplete and kept UPDATE / MERGE INTO data-evolution paths outside the builder flow.This PR introduces
TableUpdateas the table-level update API and wires data-evolution UPDATE / MERGE INTO throughWriteBuilder::new_update(...).Brief change log
TableUpdateas a thin wrapper aroundDataEvolutionWriter.WriteBuilder::new_update(update_columns).TableUpdatefrompaimon::tableand crate root.WriteBuilder.WriteBuilderfor MERGE INTO update writer, insert writer, and commit.Tests
cargo fmt --all -- --checkcargo clippy -p paimon -p paimon-datafusion --all-targets --features fulltext,vortex -- -D warningscargo test -p paimon table::write_buildercargo test -p paimon table::data_evolution_writercargo test -p paimon-datafusion --test update_testscargo test -p paimon-datafusion --test merge_into_testsAPI and Format
Adds public
TableUpdateandWriteBuilder::new_update(...).Documentation