perf: avoid shared pointer contention in manifest and Avro decode - #239
Merged
Conversation
Contributor
Author
lxy-9602
reviewed
Aug 24, 2026
Member
|
Could you please create a corresponding issue for this PR? For example, if there have recently been several PRs focused on improving scan performance, it would be helpful to open a dedicated issue describing that effort. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Purpose
Linked issue: #240
Reduce shared pointer contention in concurrent manifest reads and Avro decoding hot loops.
This change:
StructArray::fields()once per batch inManifestFile::ReadBucketEntries()andObjectsFile<T>::Read(), avoiding repeated copies ofshared_ptr<Array>for every row.AvroDirectDecoder::DecodeContext, including:ArrayBuilder::type()for every value.SetReadSchema()replaces the builder tree, preventing staleentries if builder addresses are reused.
Tests
paimon-avro-format-testsuccessfully.pre-commit run --filesfor all changed files: passed.git diff --check: passed.paimon-core-testcould not be fully linked because of an unrelated existing Parquet/Arrow APImismatch in
page_filtered_row_group_reader.cpp: the current ArrowGetColumnoverload expectsconst std::vector<int>&, while the existing source passesstd::shared_ptr<std::unordered_set<int>>.API and Format
No public API, storage format, or protocol changes.
Documentation
No new user-facing feature or documentation change.
Generative AI tooling
Generated-by: OpenAI Codex (GPT-5)