fix(rest): support libcurl versions before 7.49 - #237
Open
wangyong9999 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: N/A.
Paimon enables REST with
find_package(CURL REQUIRED)and does not declare a minimum libcurl version. However,IsRetriableTransportErrorunconditionally referencesCURLE_HTTP2_STREAM, which was added in libcurl 7.49.0. Building REST support with an older supported libcurl, such as 7.46.0, therefore fails at compile time.Guard the enum case with
CURL_AT_LEAST_VERSION(7, 49, 0). Builds using libcurl 7.49 or newer retain the existing retry classification; older libcurl versions cannot return an error code they do not define.Tests
git diff --checkpasses.core_test: 1809/1809 passed.RestHttpClientTest.*: 26/26 passed.Coverage
The curl 7.46.0 build validates the pre-7.49 compile-time branch. Existing builds with newer libcurl retain the
CURLE_HTTP2_STREAMcase. No separate line or branch coverage report was generated.API and Format
This change does not affect public APIs, storage formats, or protocols.
Documentation
This change does not introduce a user-visible feature; no documentation update is required.
Generative AI tooling
Generated-by: Codex (GPT-5)