Skip to content

feat(realtime): improve append table lifecycle and query support - #213

Open
lxy-9602 wants to merge 7 commits into
apache:mainfrom
lxy-9602:rt-append-todo
Open

feat(realtime): improve append table lifecycle and query support#213
lxy-9602 wants to merge 7 commits into
apache:mainfrom
lxy-9602:rt-append-todo

Conversation

@lxy-9602

Copy link
Copy Markdown
Collaborator

Purpose

Linked issue: #158

This PR completes several follow-up capabilities for append-table real-time reads and writes:

  • support batch-level statistics and predicate pushdown in the default Arrow RealtimeStore;
  • support count readers and independently schedulable disk splits;
  • make CommitWithProgress retries idempotent;
  • preserve real-time progress across compaction and require context recreation after rollback;
  • clean up expired and orphan real-time offset files;
  • extend integration coverage for commit retry, compaction, rollback, schema rename, predicate pushdown, offset cleanup, and memory reclamation.

Tests

API and Format

  • Adds the realtime.store.stats-mode option with none and full modes.
  • Adds StatisticsMode to RealtimeStoreFactory::Create.
  • Clarifies retry and rollback behavior in the public APIs.

Documentation

Generative AI tooling

Generated-by: OpenAI Codex (GPT-5)

@zjw1111 zjw1111 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the realtime lifecycle / query changes. A few questions on the commit idempotency model and on StatisticsMode semantics, two perf points worth confirming, plus one test-coverage gap and three style nits. Inline.

Comment thread src/paimon/core/operation/file_store_commit_impl.cpp
Comment thread src/paimon/core/realtime/arrow_realtime_store.cpp
Comment thread include/paimon/realtime/realtime_store.h Outdated
Comment thread src/paimon/core/operation/expire_snapshots.cpp Outdated
Comment thread src/paimon/core/operation/file_store_commit_impl.cpp
Comment thread src/paimon/core/operation/expire_snapshots.cpp
Comment thread src/paimon/core/realtime/arrow_realtime_store_test.cpp Outdated
Comment thread src/paimon/core/core_options.h Outdated
Comment thread src/paimon/core/realtime/arrow_realtime_store_test.cpp Outdated
Comment thread src/paimon/core/table/source/append_count_reader.cpp Outdated
Comment thread src/paimon/core/core_options.h

@zjw1111 zjw1111 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants