Skip to content

chore: clean up bitmap and CMake compatibility declarations - #193

Merged
SteNicholas merged 2 commits into
apache:mainfrom
zjw1111:codex/remove-bitmap-index-readme-note
Aug 11, 2026
Merged

chore: clean up bitmap and CMake compatibility declarations#193
SteNicholas merged 2 commits into
apache:mainfrom
zjw1111:codex/remove-bitmap-index-readme-note

Conversation

@zjw1111

@zjw1111 zjw1111 commented Aug 11, 2026

Copy link
Copy Markdown
Collaborator

Purpose

Linked issue: N/A

This change cleans up two obsolete compatibility declarations:

  • Remove the outdated README note that describes the bitmap global index type as unsupported.
  • Remove the CMake 3.24-only DOWNLOAD_EXTRACT_TIMESTAMP arguments from the bundled AWS authentication dependencies so the declared CMake 3.22 minimum is honored.

CMake 3.24 and newer retain extraction-time timestamps through the existing CMP0135 NEW policy setting. CMake 3.22 and 3.23 use the older timestamp behavior, which is acceptable for this project.

Users get accurate bitmap compatibility documentation, and S3 builds can be configured with the documented minimum CMake version.

Tests

  • CMake 3.22.6 configuration with -DPAIMON_ENABLE_S3=ON -DPAIMON_BUILD_TESTS=OFF
  • pre-commit run --files README.md
  • pre-commit run --files cmake_modules/BuildAwsAuth.cmake
  • git diff --check

API and Format

No API, storage format, or protocol changes.

Documentation

Removes an outdated compatibility note from README.md; no new feature is introduced.

Generative AI tooling

Generated-by: Codex (GPT-5)

@zjw1111
zjw1111 force-pushed the codex/remove-bitmap-index-readme-note branch from 2ddb83d to 4cf046d Compare August 11, 2026 05:07
@zjw1111
zjw1111 marked this pull request as ready for review August 11, 2026 05:09
@zjw1111 zjw1111 changed the title docs: remove bitmap global index compatibility note chore: clean up bitmap and CMake compatibility declarations Aug 11, 2026

@lxy-9602 lxy-9602 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@SteNicholas SteNicholas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@SteNicholas
SteNicholas merged commit fa37cb0 into apache:main Aug 11, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants