HDDS-14682. Unify OzoneManagerProtocolPB failover proxy provider#9929
Open
ivandika3 wants to merge 5 commits intoapache:masterfrom
Open
HDDS-14682. Unify OzoneManagerProtocolPB failover proxy provider#9929ivandika3 wants to merge 5 commits intoapache:masterfrom
ivandika3 wants to merge 5 commits intoapache:masterfrom
Conversation
The unified HadoopRpcOMFollowerReadFailoverProxyProvider hardcoded useFollowerRead=true, ignoring ozone.client.follower.read.enabled (default false). This forced all read-eligible requests through the LINEARIZABLE_ALLOW_FOLLOWER server path instead of DEFAULT, causing test timeouts due to the different Ratis execution flow. Pass the config value through the constructor so follower read behavior matches the configuration. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Since HadoopRpcOMFollowerReadFailoverProxyProvider should be able to support both OM follower and OM leader request flows, we can always use HadoopRpcOMFollowerReadFailoverProxyProvider for the OzoneManagerProtocolPB failover proxy provider. This will unify some of the implementations such as the client read consistency implementation in HDDS-14509.
This means that HadoopRpcOMFailoverProxyProvider is only used for other OM non-OzoneManagerProtocolPB protocols (e.g. OMAdminProtocolPB).
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-14682
How was this patch tested?
Existing CI (Clean CI: https://github.com/ivandika3/ozone/actions/runs/23105516389)