HDDS-14740. Implement ScmListCodec without reflection#9919
Open
Russole wants to merge 6 commits intoapache:masterfrom
Open
HDDS-14740. Implement ScmListCodec without reflection#9919Russole wants to merge 6 commits intoapache:masterfrom
Russole wants to merge 6 commits intoapache:masterfrom
Conversation
Contributor
Author
|
Hi @szetszwo, could you please help review this PR when you have time? Thanks! |
szetszwo
reviewed
Mar 14, 2026
| message MethodArgument { | ||
| optional string type = 1; | ||
| optional bytes value = 2; | ||
| optional string genericType = 3; |
Contributor
There was a problem hiding this comment.
@Russole , since the existing code can serialize/deserialize, the protos should have enough information, i.e. we probably don't need to add new fields to the protos. Let me see about how to do it.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Record generic type information when constructing SCMRatisRequest; otherwise getCodec() and decode() cannot determine the element type of List.
genericTypefield toMethodArgumentinSCMRatisProtocol.prototo store the element type T ofList<T>.genericTypefield toSCMRatisResponsePrototo preserve generic type information in responses.SCMRatisRequestandSCMRatisResponse encode()to includegenericTypewhen the parameter isList<T>.SCMRatisRequestandSCMRatisResponsedecode()to reconstruct the corresponding genericType.genericParameterTypesparameter toSCMRatisRequestandSCMRatisResponseconstructors to preserve generic type information.getCodec(Type type)andgetOrCreateListCodec()inScmCodecFactoryto support resolving codecs forList<T>.ScmListCodecto support generic element types instead of inferring the type from runtime values.ScmListCodecinstances forList<T>based on the element type.What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-14740
How was this patch tested?