HDDS-14765. Improve Trace Hierarchy for Ozone Shell Put Key Command#9908
Open
sravani-revuri wants to merge 3 commits intoapache:masterfrom
Open
HDDS-14765. Improve Trace Hierarchy for Ozone Shell Put Key Command#9908sravani-revuri wants to merge 3 commits intoapache:masterfrom
sravani-revuri wants to merge 3 commits intoapache:masterfrom
Conversation
Contributor
Author
|
@sumitagrawl , could you please review these changes. |
Contributor
Gargi-jais11
left a comment
There was a problem hiding this comment.
Thanks @sravani-revuri for the patch.
Please find inlined comments.
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/tracing/TracingUtil.java
Outdated
Show resolved
Hide resolved
Contributor
|
@sravani-revuri Please add some tests in either
|
Gargi-jais11
approved these changes
Mar 13, 2026
Contributor
Gargi-jais11
left a comment
There was a problem hiding this comment.
Thanks @sravani-revuri for updating the patch. Overall LGTM.
Contributor
|
@Gargi-jais11 please quote Java annotations ( |
Contributor
Thanks @adoroszlai, realised it just now when I checked it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The tracing for the put key command is currently fragmented. Instead of one continuous trace with multiple spans, each function call opens a new trace as a separate root.
Proposed Changes
The goal is to ensure all actions belong to the same trace using a parent-child hierarchy.
Modify TracingUtil to check for an existing trace context before creating a new span:
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-14765
How was this patch tested?
Tested with Jaeger UI using Docker.
