HDDS-14732. Create a new VersionManager for unified component versioning#9897
Draft
errose28 wants to merge 20 commits intoapache:HDDS-14496-zdufrom
Draft
HDDS-14732. Create a new VersionManager for unified component versioning#9897errose28 wants to merge 20 commits intoapache:HDDS-14496-zdufrom
errose28 wants to merge 20 commits intoapache:HDDS-14496-zdufrom
Conversation
(cherry picked from commit 89fc4ca) (cherry picked from commit 9bf5c8ac6333b0d7e45e12ff537fd1a975b103e7)
Contributor
Author
|
@sodonnel @dombizita @octachoron This PR should be ready for review. I've completed a re-review of the changes on my end and the CI is still progressing on my fork. The patch is quite large, but no single file has more than ~150 lines added and it provides the whole picture of how the component version manager uses the changes to the features/versions. If you think it would be easier to review in smaller parts I can optionally split it into three ~500 line PRs:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
ComponentVersionManagerclass which tracks apparent version, software version, and finalization status using the new unified version framework based around component version.nextVersionmethod to allComponentVersionswhich points from the current version to the one immediately following it for use when finalizing.HDDSLayoutFeatureandOMLayoutFeature's last version'snextVersionimplementations point toHDDSVersion#ZDUandOzoneManagerVersion#ZDUrespectively to handle the transition from layout feature to component version during finalization.ComponentVersionManagerimplementation will work whether or not we are finalized for ZDU, because it can depend on thenextVersioncall to transparently make the switch when finalizing.A follow-up change will switch the current upgrade path from using
AbstractLayoutVersionManagerand its subclasses to the newComponentVersionManager.What is the link to the Apache JIRA
HDDS-14732
How was this patch tested?
Draft until all testing is finished
LayoutFeatureandComponentVersionaddedComponentVersionManageraddedNote:
TestOMVersionManagerwas originally the test suite forOMLayoutVersionManager. It was renamed toTestOMLayoutVersionManagerto reflect this. Then a new classTestOMVersionManagerwas created to test the corresponding new classOMVersionManager. Git does not correctly reflect this, and showsTestOMLayoutVersionManageras a completely new class whileOMVersionManagerappears to have had almost all content deleted and replaced.