HDDS-15962. Remove leader readiness check on the bootstrap flow.#10862
Draft
sadanand48 wants to merge 1 commit into
Draft
HDDS-15962. Remove leader readiness check on the bootstrap flow.#10862sadanand48 wants to merge 1 commit into
sadanand48 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Current logic rejects checkpoint requests with 503 unless isLeaderReady() is true.
In a degraded cluster (e.g., one OM down, one follower far behind), this creates a loop:
Lagging follower needs checkpoint to catch up.
Follower requests /v2/dbCheckpoint from leader.
Leader is LEADER_AND_NOT_READY and returns 503 due to isLeaderReady() check.
Follower cannot catch up, so leader readiness does not progress.
System remains stuck until another OM is brought back.
Checkpoint creation already has consistency barriers:
awaitDoubleBufferFlush()
bootstrap write lock (BOOTSTRAP_LOCK)
So requiring LEADER_AND_READY here is stricter than necessary and can block recovery. instead only reject if NOT_LEADER
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-15962
How was this patch tested?
Unit tests