HDDS-15178. Allow creating EncodingTypeObject for empty String#10195
Merged
peterxcli merged 1 commit intoapache:masterfrom May 6, 2026
Merged
HDDS-15178. Allow creating EncodingTypeObject for empty String#10195peterxcli merged 1 commit intoapache:masterfrom
peterxcli merged 1 commit intoapache:masterfrom
Conversation
…of empty string; update tests to cover new behavior. Signed-off-by: peterxcli <peterxcli@gmail.com>
peterxcli
changed the title
Member
Author
|
I notice the jira ticket this PR for should be as a subtask under https://issues.apache.org/jira/browse/HDDS-8423, is there any way to fix it? I couldn't found the move option. |
Contributor
Moved.
It is in the "More" popup. |
adoroszlai
approved these changes
May 6, 2026
Contributor
adoroszlai
left a comment
adoroszlai
left a comment
There was a problem hiding this comment.
Thanks @peterxcli for the patch, LGTM.
adoroszlai
changed the title
Member
Author
|
@adoroszlai Thanks for the review and the help!
Looks like I don't have that option because I don't have enough permission level, maybe only PMC Member can do this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Updates the handling of empty string values for the
nameparameter in theEncodingTypeObjectclass, ensuring that empty strings are treated as valid (rather than null) and are properly marshaled and tested. It also improves test coverage and correctness for these cases.this fixes two s3-test test cases:
relate to: #4127
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-15178
How was this patch tested?
(Please explain how this patch was tested. Ex: unit tests, manual tests, workflow run on the fork git repo.)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this.)