HDDS-15177. acceptance test race condition in generating keytab and service start.#10194
Open
ss77892 wants to merge 1 commit intoapache:masterfrom
Open
HDDS-15177. acceptance test race condition in generating keytab and service start.#10194ss77892 wants to merge 1 commit intoapache:masterfrom
ss77892 wants to merge 1 commit intoapache:masterfrom
Conversation
adoroszlai
reviewed
May 6, 2026
Contributor
adoroszlai
left a comment
adoroszlai
left a comment
There was a problem hiding this comment.
Thanks @ss77892 for the patch.
Comment on lines
+41
to
+46
| healthcheck: | ||
| test: ["CMD-SHELL", "test -s /etc/security/keytabs/scm.keytab && nc -z 127.0.0.1 88"] | ||
| interval: 2s | ||
| timeout: 3s | ||
| retries: 45 | ||
| start_period: 5s |
Contributor
There was a problem hiding this comment.
- Checking existence of
scm.keytabis not necessary, since KDC is started (ininit-kdc.sh) only after exporting all keytabs. - I think it would be better to add the healthcheck in the image itself to reduce duplication. Base command may need to be set (
krb5kdc -n), too. With that, we only needdepends_onin compose files (and updatedocker.ozone-testkr5b.image)
Comment on lines
+60
to
+62
| depends_on: | ||
| kdc: | ||
| condition: service_healthy |
Contributor
There was a problem hiding this comment.
This seems to be unnecessary, since /etc/security/keytabs is not mounted, so KMS cannot use keytabs created by KDC.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
HDDS-15177. acceptance test race condition in generating keytab and service start.
Fix intermittent xcompat failures where the new-cluster Compose stack could start SCM and other Kerberos-backed services before init-kdc finished exporting keytabs and starting the KDC. Add the same KDC healthcheck used on the old cluster (verify scm.keytab exists and port 88 accepts connections) and depend on the KDC being healthy.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-15177
How was this patch tested?
CI + local tests.