HDDS-15175. Introduce StorageClass and storage policy#10191
Open
xichen01 wants to merge 2 commits intoapache:HDDS-11233from
Open
HDDS-15175. Introduce StorageClass and storage policy#10191xichen01 wants to merge 2 commits intoapache:HDDS-11233from
xichen01 wants to merge 2 commits intoapache:HDDS-11233from
Conversation
chungen0126
reviewed
May 5, 2026
Contributor
chungen0126
left a comment
chungen0126
left a comment
There was a problem hiding this comment.
Thanks @xichen01 for the patch. Overall, looks good to me, but I have a few minor suggestions.
| return StoragePolicyProto.COLD; | ||
| default: | ||
| throw new IllegalArgumentException( | ||
| "Error: StoragePolicyType not found, type=" + this); |
Contributor
There was a problem hiding this comment.
nit: The class name is OzoneStoragePolicy.
Suggested change
| "Error: StoragePolicyType not found, type=" + this); | |
| "Error: OzoneStoragePolicy not found, type=" + this); |
| if (storageTypes.isEmpty()) { | ||
| return Collections.emptyList(); | ||
| } | ||
| return new ArrayList<>(Collections.nCopies(numberOfNodes, storageTypes.get(0))); |
Contributor
There was a problem hiding this comment.
Should we consider making the StorageType list read-only to ensure immutability?
Suggested change
| return new ArrayList<>(Collections.nCopies(numberOfNodes, storageTypes.get(0))); | |
| return Collections.unmodifiableList(new ArrayList<>(Collections.nCopies(numberOfNodes, storageTypes.get(0))); |
Comment on lines
+64
to
+69
| if (Arrays.stream(storageTypes).distinct().count() <= 1) { | ||
| throw new IllegalArgumentException("StorageTier '" + tierName + | ||
| "' requires at least two different StorageType instances." + | ||
| " but only " + Arrays.stream(storageTypes).distinct().count() + | ||
| " StorageType were provided."); | ||
| } |
Contributor
There was a problem hiding this comment.
While I understand that non-uniform storage tiers aren't supported yet (so this line might not be reachable), Arrays.stream(storageTypes).distinct().count() is called twice here. We could assign it to a variable instead.
Suggested change
| if (Arrays.stream(storageTypes).distinct().count() <= 1) { | |
| throw new IllegalArgumentException("StorageTier '" + tierName + | |
| "' requires at least two different StorageType instances." + | |
| " but only " + Arrays.stream(storageTypes).distinct().count() + | |
| " StorageType were provided."); | |
| } | |
| long distinctStorageTypes = Arrays.stream(storageTypes).distinct().count(); | |
| if (distinctStorageTypes <= 1) { | |
| throw new IllegalArgumentException("StorageTier '" + tierName + | |
| "' requires at least two different StorageType instances." + | |
| " but only " + distinctStorageTypes + | |
| " StorageType were provided."); | |
| } |
| import org.apache.hadoop.hdds.client.StorageTier; | ||
| import org.junit.jupiter.api.Test; | ||
|
|
||
| class StoragePolicyTest { |
Contributor
There was a problem hiding this comment.
Could you please add some unit tests to cover the Protobuf/Java conversion?
greenwich
reviewed
May 5, 2026
| * Ozone specific storage tiers. | ||
| */ | ||
| public enum StorageTier { | ||
| SSD("SSD", StorageType.SSD), |
Contributor
There was a problem hiding this comment.
Do you think we may introduce the NVME storage type (here and below where it's needed)?
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Introduce StorageClass and storage policy, introducing storage policy related definitions
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-15175
How was this patch tested?
unit test