HDDS-15149. Limit Connections Created by DataNode GRPC Server#10184
Open
YutaLin wants to merge 8 commits intoapache:masterfrom
Open
HDDS-15149. Limit Connections Created by DataNode GRPC Server#10184YutaLin wants to merge 8 commits intoapache:masterfrom
YutaLin wants to merge 8 commits intoapache:masterfrom
Conversation
YutaLin
force-pushed
the
HDDS-15149_limit_connections_on_datanode_grpc
branch
from
e8a5efc to
10ff1ee
Compare
YutaLin
force-pushed
the
HDDS-15149_limit_connections_on_datanode_grpc
branch
from
19383d1 to
63e6c63
Compare
ChenSammi
reviewed
May 5, 2026
| xceiverService.bindServiceWithZeroCopy(), | ||
| new GrpcServerInterceptor())); | ||
| new GrpcServerInterceptor())) | ||
| .addTransportFilter(connectionLimitFilter); |
Contributor
There was a problem hiding this comment.
@YutaLin , thanks for working on this.
Could you try use NettyServerBuilder's withChildOption, to set ChannelOption.SO_BACKLOG?
Contributor
Author
There was a problem hiding this comment.
Hi @ChenSammi, thanks for the review,
I've added so_backlog to prevent burst connections, also keep connection limit filter to control sustained high connection.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Currently there is no limited control of network connections created by Datanode GRPC server, which caused "too many open files" issue in Datanode, 126920 TCP connections out of 128103 total open file handlers.
Introduce
GrpcConnectionLimitFilterto control connections and add set default max connections to 5,000, leaves most of the fds for files/DBs. Also add os_backlog to control burst connections.What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-15149
How was this patch tested?
Add test for connection limit filter and node configuration, also run ci tests.