chore(goosefs): bump goosefs-sdk to 0.1.7 by XuQianJin-Stars · Pull Request #7918 · apache/opendal

XuQianJin-Stars · 2026-07-16T09:31:27Z

Upgrade goosefs-sdk dependency to >=0.1.7, <0.3.0 to use the published 0.1.7
release. The version range leaves room for bug fix releases (0.1.x and 0.2.x)
without breaking changes.

Which issue does this PR close?

Closes #.

Rationale for this change

The published goosefs-sdk 0.1.7 release contains fixes/improvements that we want
to adopt. Bumping the lower bound to 0.1.7 ensures consumers build against a
correct, supported SDK version. Specifying an upper bound of <0.3.0 (instead of
pinning to 0.1.x) allows compatible bug-fix releases (0.1.x and 0.2.x) to be
picked up automatically via Cargo's semver resolution, without introducing
breaking changes.

What changes are included in this PR?

Update the goosefs-sdk dependency in core/services/goosefs/Cargo.toml from
the previous version range to >=0.1.7, <0.3.0.

Are there any user-facing changes?

No. This is a dependency version bump only; no public API, configuration, or
behavioral changes for OpenDAL users.

AI Usage Statement

This PR was developed with the assistance of AI coding tools (Claude, used for code scaffolding, documentation drafting, and review). All generated code has been manually reviewed, compiled, tested (cargo build / cargo test / cargo clippy), and verified against a live GooseFS cluster.

erickguan

Good. Can you rebase and remove obsolete comment?

erickguan

Thank you!

erickguan · 2026-07-16T10:13:00Z

@XuQianJin-Stars Can you watch CI status? I noticed an error and the second run stuck in pulling goosefs image.

XuQianJin-Stars · 2026-07-16T11:36:57Z

@XuQianJin-Stars Can you watch CI status? I noticed an error and the second run stuck in pulling goosefs image.

Thanks for the reminder! I'll monitor the CI status and look into the error and the goosefs image pulling issue. Let's not merge until CI is fully green.

erickguan · 2026-07-16T11:56:03Z

+            return Ok(());
+        };
+
+        const MAX_ATTEMPTS: usize = 5;


Is this a reliable approach? Does goosefs provide write consistency guarantee?

Upgrade goosefs-sdk dependency to >=0.1.7, <0.3.0 to use the published 0.1.7 release. The version range leaves room for bug fix releases (0.1.x and 0.2.x) without breaking changes.

erickguan · 2026-07-16T16:41:24Z

+        # Disable the GooseFS SDK's FileInfoCache (default TTL 30s) so
+        # behavior tests observe fresh metadata immediately after
+        # write/delete/rename instead of a stale cached snapshot.
+        GOOSEFS_FILE_INFO_CACHE_TTL_MS=0


If we rely on an environment variable for tests to pass but not integrate into code, this would produce surprising results for users.

If we rely on an environment variable for tests to pass but not integrate into code, this would produce surprising results for users.

The intent here was just to reduce caching to lower CI memory usage. I agree relying on the env var alone is fragile

erickguan · 2026-07-16T16:49:20Z

        OPENDAL_GOOSEFS_MASTER_ADDR=127.0.0.1:9200
        OPENDAL_GOOSEFS_ROOT=/
        OPENDAL_GOOSEFS_WRITE_TYPE=must_cache
+        # Disable the GooseFS SDK's FileInfoCache (default TTL 30s) so


You can put # to the top of cat or before run block.

erickguan · 2026-07-16T16:50:24Z

-        let master = self.master().await?;
+        let ctx = self.ctx().await?;
+        let master = ctx.acquire_master();
+        // A3 consistency: mirror the SDK's `BaseFileSystem::delete`, which


What is A3 consistency?

Xuanwo · 2026-07-16T16:56:25Z

-# in its io_uring cache store without importing `std::ffi::CString`. Bindings do
-# not commit lockfiles and otherwise resolve that broken release in CI.
-goosefs-sdk = "=0.1.5"
+goosefs-sdk = { version = ">=0.1.7, <0.3.0" }


What's <0.3.0 means?

Xuanwo · 2026-07-16T16:58:42Z

Wait a minute, goosefs-sdk itself is not even an open source project? I am going to remove goose-related support from the tree. It's unaccpetable for opendal to have such deps. It should be fine to maintain an oepndal-service-goosefs crate externally.

https://git.woa.com/tencent-cloud-datalake/goosefs-client-rust

erickguan · 2026-07-16T17:12:21Z

@Xuanwo We can add a short guideline since Apache License is kind of special.

Also to check my understanding, we can't distribute a non-OSS SDK. But it's fine to distribute an optional module (also can be in a repo) under Apache License/other compatible license.

Xuanwo · 2026-07-16T18:04:56Z

But it's fine to distribute an optional module (also can be in a repo) under Apache License/other compatible license.

No, we can't have such deps in the tree. This will be a blocker for our release.

goosefs-sdk declared itself to be apache 2.0 licensed but it's non-OSS at all.

Either we address this issue, or we remove it before the next release.

erickguan · 2026-07-16T18:56:25Z

@Xuanwo I meant this service can't be in opendal repo. Can we host it in apache/opendal-x or somewhere outside apache?

Understand. This is a blocker for release. I'm going to check this PR and take care of license.

erickguan · 2026-07-16T23:45:44Z

@Xuanwo I audit the crate which is Apache licensed. Its website and repo https://git.woa.com/tencent-cloud-datalake/goosefs-client-rust is private. Since we can view the code and license file is present, we are good to have goosefs service.

It's just less convenient to read documentation or collaborate with goosefs developers.

Xuanwo · 2026-07-16T23:56:33Z

@Xuanwo I audit the crate which is Apache licensed. Its website and repo https://git.woa.com/tencent-cloud-datalake/goosefs-client-rust is private. Since we can view the code and license file is present, we are good to have goosefs service.

It's just less convenient to read documentation or collaborate with goosefs developers

This is an interesting direction. From my position, it's not acceptable since tencent people can do anything in the code. And it's unlikely for us to check source from crates every-time.

I have communicated with @XuQianJin-Stars and hope he can have some good solutions for this.

We can wait until his response.

XuQianJin-Stars · 2026-07-16T23:57:10Z

Wait a minute, goosefs-sdk itself is not even an open source project? I am going to remove goose-related support from the tree. It's unaccpetable for opendal to have such deps. It should be fine to maintain an oepndal-service-goosefs crate externally.

https://git.woa.com/tencent-cloud-datalake/goosefs-client-rust

Hi @Xuanwo, thanks for pointing this out, and apologies for the confusion.

You're right that goosefs-sdk is currently not open source yet — the link you found points to our internal repository. We're actively working on open-sourcing it and expect to complete this within the next few days.

Once it's publicly available, the dependency will be resolved through a properly published, open-source crate. In the meantime, if you'd prefer, we're happy to maintain an goosefs-client-rust crate externally so that OpenDAL's tree stays clean of any non-open-source dependencies.

Please let us know which approach works best for you, and thanks for your patience!

Xuanwo · 2026-07-17T00:04:17Z

Thank you for that. I think make it open source is the best plan.

In the meantime, if you'd prefer, we're happy to maintain an goosefs-client-rust crate externally so that OpenDAL's tree stays clean of any non-open-source dependencies.

Introduces another new dep (alias) might be confusing.

erickguan · 2026-07-17T00:42:13Z

Happy to see SDK as OSS project and host publicly. @XuQianJin-Stars Next patch release will be in 1-2 weeks.

- .github/services/goosefs/goosefs/action.yml: GOOSEFS_FILE_INFO_CACHE_TTL_MS=0 and its explanatory comment are no longer needed in the behavior test setup; remove them so the env step only sets the core OPENDAL_GOOSEFS_* vars (MASTER_ADDR, ROOT, WRITE_TYPE). - core/services/goosefs/src/core.rs: remove the verbose "A3 consistency" comments in delete() and rename(); keep the invalidate_file_info() calls (cheap no-ops when the opt-in cache is disabled) so the contract still holds if the cache is ever enabled.

XuQianJin-Stars requested a review from Xuanwo as a code owner July 16, 2026 09:31

dosubot Bot added size:L This PR changes 100-499 lines, ignoring generated files. releases-note/chore The PR has a title that begins with "chore" or changes other small things that hard to tell labels Jul 16, 2026

erickguan requested changes Jul 16, 2026

View reviewed changes

Comment thread core/services/goosefs/Cargo.toml

XuQianJin-Stars force-pushed the chore/bump-goosefs-sdk-to-0.1.7 branch from e30868b to 03ec161 Compare July 16, 2026 09:45

erickguan approved these changes Jul 16, 2026

View reviewed changes

dosubot Bot added the lgtm This PR has been approved by a maintainer label Jul 16, 2026

erickguan reviewed Jul 16, 2026

View reviewed changes

XuQianJin-Stars force-pushed the chore/bump-goosefs-sdk-to-0.1.7 branch from e5a48e7 to 7256be4 Compare July 16, 2026 15:11

dosubot Bot added size:XS This PR changes 0-9 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Jul 16, 2026

XuQianJin-Stars force-pushed the chore/bump-goosefs-sdk-to-0.1.7 branch from 7256be4 to 5e1c644 Compare July 16, 2026 16:01

dosubot Bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Jul 16, 2026

chore(goosefs): bump goosefs-sdk to 0.1.7

91c99a0

Upgrade goosefs-sdk dependency to >=0.1.7, <0.3.0 to use the published 0.1.7 release. The version range leaves room for bug fix releases (0.1.x and 0.2.x) without breaking changes.

XuQianJin-Stars force-pushed the chore/bump-goosefs-sdk-to-0.1.7 branch from 5e1c644 to 91c99a0 Compare July 16, 2026 16:11

test(goosefs): disable FileInfoCache in behavior test env

7c85c4c

XuQianJin-Stars requested a review from tisonkun as a code owner July 16, 2026 16:28

erickguan self-requested a review July 16, 2026 16:40

erickguan reviewed Jul 16, 2026

View reviewed changes

erickguan self-requested a review July 16, 2026 16:47

erickguan reviewed Jul 16, 2026

View reviewed changes

erickguan requested changes Jul 16, 2026

View reviewed changes

dosubot Bot removed the lgtm This PR has been approved by a maintainer label Jul 16, 2026

Xuanwo requested changes Jul 16, 2026

View reviewed changes

XuQianJin-Stars force-pushed the chore/bump-goosefs-sdk-to-0.1.7 branch 2 times, most recently from d9d2f50 to 8c453bd Compare July 18, 2026 01:40

XuQianJin-Stars force-pushed the chore/bump-goosefs-sdk-to-0.1.7 branch from 8c453bd to 8a02d52 Compare July 18, 2026 01:45

dosubot Bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Jul 18, 2026

Uh oh!

Conversation

XuQianJin-Stars commented Jul 16, 2026

Which issue does this PR close?

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

AI Usage Statement

Uh oh!

erickguan left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

erickguan left a comment

Choose a reason for hiding this comment

Uh oh!

erickguan commented Jul 16, 2026

Uh oh!

XuQianJin-Stars commented Jul 16, 2026

Uh oh!

erickguan Jul 16, 2026

Choose a reason for hiding this comment

Uh oh!

erickguan Jul 16, 2026

Choose a reason for hiding this comment

Uh oh!

XuQianJin-Stars Jul 18, 2026

Choose a reason for hiding this comment

Uh oh!

erickguan Jul 18, 2026

Choose a reason for hiding this comment

Uh oh!

erickguan Jul 16, 2026

Choose a reason for hiding this comment

Uh oh!

erickguan Jul 16, 2026

Choose a reason for hiding this comment

Uh oh!

Xuanwo Jul 16, 2026

Choose a reason for hiding this comment

Uh oh!

Xuanwo commented Jul 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

erickguan commented Jul 16, 2026

Uh oh!

Xuanwo commented Jul 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

erickguan commented Jul 16, 2026

Uh oh!

erickguan commented Jul 16, 2026

Uh oh!

Xuanwo commented Jul 16, 2026

Uh oh!

XuQianJin-Stars commented Jul 16, 2026

Uh oh!

Xuanwo commented Jul 17, 2026

Uh oh!

erickguan commented Jul 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Xuanwo commented Jul 16, 2026 •

edited

Loading

Xuanwo commented Jul 16, 2026 •

edited

Loading