feat(services/webdav): support conditional read headers#7637
Open
YuangGao wants to merge 1 commit into
Open
Conversation
dosubot
Bot
added
size:S
YuangGao
force-pushed
the
feat/webdav-conditional-read
branch
from
acc918e to
4879d7d
Compare
dosubot
Bot
added
size:M
YuangGao
force-pushed
the
feat/webdav-conditional-read
branch
from
4879d7d to
ac45f57
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #5486.
Rationale for this change
The webdav service already supports read but ignored the
OpReadargument, so conditional headers never reached the GET request. Per RFC 7232 (HTTP/1.1 conditional requests, inherited by WebDAV servers),If-Match/If-None-Match/If-Modified-Since/If-Unmodified-Sinceare standard on GET.What changes are included in this PR?
webdav_get.read_with_if_match,read_with_if_none_match,read_with_if_modified_since,read_with_if_unmodified_sinceon the webdav service capability.Stat-side conditional support (PROPFIND) is left for a follow-up because
webdav_statdoesn't currently acceptOpStatand PROPFIND conditional semantics are server-dependent.Are there any user-facing changes?
Yes —
op.reader_with(path).if_match(...)(and the three siblings) now work against webdav backends. No breaking changes;AI Usage Statement
AI-assisted implementation.