Improved: Prevent potential resource leak in FtpServices.java putFile/getFile (OFBIZ-13427)#1300
Open
chandan-khandelwal wants to merge 1 commit into
Open
Improved: Prevent potential resource leak in FtpServices.java putFile/getFile (OFBIZ-13427)#1300chandan-khandelwal wants to merge 1 commit into
chandan-khandelwal wants to merge 1 commit into
Conversation
…/getFile (OFBIZ-13427)
chandan-khandelwal
changed the title
Contributor
|
Hello @chandan-khandelwal, you pull request is ready to merge ? I looked that you change the try/catch block declaration, is enough escape the resource leak ? |
Contributor
Author
|
Yes @nmalin the pull request is ready to merge. The code now properly closes the resource, so this should address the reported resource leak issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improved: Prevent potential resource leak in FtpServices.java putFile/getFile (OFBIZ-13427)
We refactored putFile and getFile in FtpServices.java to use try-with-resources, ensuring local file streams are always closed automatically to prevent file descriptor leaks.